[Webkit-unassigned] [Bug 161409] [JSC] Implement parsing of Async Functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161409

--- Comment #46 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Comment on attachment 289447
  --> https://bugs.webkit.org/attachment.cgi?id=289447
Async Function Parsing v6 + Copy-edit the build-jsc help message changes

View in context: https://bugs.webkit.org/attachment.cgi?id=289447&action=review

>> Source/JavaScriptCore/ChangeLog:87
>> +        * runtime/CommonIdentifiers.h:
> 
> Could you update this ChangeLog by using Tools/Scripts/webkit-patch upload --update-changelogs?

Done

>> Source/JavaScriptCore/parser/Parser.h:1560
>> +        // FIXME: `m_moduleScopeData.get() != nullptr` is not a valid method of determining if parser is parsing a Module.
> 
> Could you open a bug for this and note the URL here?
> And I think this can be easily fixed since we already have this information: JSParserCommentMode {Classic, Module}!
> This flag is named like this since currently it is only used for controlling comment mode. When you use this information here, you need to rename this mode to something different one (maybe, JSParserScriptMode?).

For the uses in this patch, I think this actually doesn't matter here, because nested functions will never be re-parsed if `isDisallowedIdentifierAwait()` triggers an error (which it always should here).

Maybe the FIXMEs are better to just be removed.

>>> Tools/Scripts/build-jsc:211
>>> +            if ($featureEnabled != $_->{default}) {
>> 
>> For string, we need to use ne instead of !=. This causes warnings.
> 
> Not just warnings, incorrect behavior! Using != causes it to do a numeric comparison, not a string one. For example, ("ON" != "OFF") is false because both strings have a numeric value of 0.

Done --- Right, this was sloppily written entirely and has been fixed up. Note, the behaviour is different from build-webkit, but I don't think it should really matter. Thanks for the look and testing on cmake.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160921/c2680f41/attachment.html>