[Webkit-unassigned] [Bug 161409] [JSC] Implement parsing of Async Functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 21 16:30:32 PDT 2016


--- Comment #42 from Darin Adler <darin at apple.com> ---
Comment on attachment 289447
  --> https://bugs.webkit.org/attachment.cgi?id=289447
Async Function Parsing v6 + Copy-edit the build-jsc help message changes

View in context: https://bugs.webkit.org/attachment.cgi?id=289447&action=review

>> Tools/Scripts/build-jsc:211
>> +            if ($featureEnabled != $_->{default}) {
> For string, we need to use ne instead of !=. This causes warnings.

Not just warnings, incorrect behavior! Using != causes it to do a numeric comparison, not a string one. For example, ("ON" != "OFF") is false because both strings have a numeric value of 0.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160921/b35d3d9f/attachment.html>

More information about the webkit-unassigned mailing list