[Webkit-unassigned] [Bug 161409] [JSC] Implement parsing of Async Functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161409

Caitlin Potter (:caitp) <caitp at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289289|1                           |0
        is obsolete|                            |

--- Comment #36 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Comment on attachment 289289
  --> https://bugs.webkit.org/attachment.cgi?id=289289
Async Function Parsing v5

View in context: https://bugs.webkit.org/attachment.cgi?id=289289&action=review

I've uploaded the patch instead of manually committing, I'd like someone to sign off on the changes to build-jsc, just in case it's not quite right (and I haven't tested the cmake build for it at all)

>> Source/JavaScriptCore/parser/Parser.cpp:3174
>> +            ExpressionErrorClassifier classifier(this);
> 
> Is this necessary? parseAssignmentExpression(context) has ExpressionErrorClassifier inside it.

Acknowledged

>> Source/JavaScriptCore/parser/Parser.cpp:3522
>> +    // AwaitExpression desugared to YieldExpression
> 
> This comment is not necessary.

Acknowledged

>> Source/JavaScriptCore/parser/Parser.h:320
>> +    }
> 
> What is the purpose of this `isModule()`?

m_moduleScopeData used to be a member of Scope, so this made sense back then. I've gotten rid of this method, and just check if the one in the parser is null or not instead.

This seems to fix a bug where modules allow "await" as an identifier in nested functions (which was incorrect per https://tc39.github.io/ecma262/#prod-FutureReservedWord)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160921/b5fae9ee/attachment.html>