[Webkit-unassigned] [Bug 162246] [WinCairo] Not building since 206044

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 18:28:15 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=162246

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289290|review?                     |review-
              Flags|                            |

--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 289290
  --> https://bugs.webkit.org/attachment.cgi?id=289290
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289290&action=review

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:226
> -    cookieStr.append(cookieName + "\t");
> +    cookieStr.append(String(domain + "\t"));

What's this?  If this is necessary, we should call append twice instead of appending the result of allocating a string, copying two strings, then appending it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160920/cd6b5f7c/attachment-0001.html>


More information about the webkit-unassigned mailing list