[Webkit-unassigned] [Bug 162059] New: [Win] Compile fix.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162059

            Bug ID: 162059
           Summary: [Win] Compile fix.
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: pvollan at apple.com

If the JavaScripCore folder with forwarding headers contains the inspector folder with derived sources, I get the following compile error:

webkitbuild\release\derivedsources\forwardingheaders\javascriptcore\InspectorProtocolObjects.h(304): error C2995: 'WTF::String Inspector::Protocol::InspectorHelpers::getEnumConstantValue(T)': function template has already been defined (compiling source file C:\Projects\WebKit2\OpenSource\Source\WebCore\inspector\InspectorAllInOne.cpp)
\webkitbuild\release\derivedsources\forwardingheaders\javascriptcore\inspector\InspectorProtocolObjects.h(301): note: see declaration of 'Inspector::Protocol::InspectorHelpers::getEnumConstantValue' (compiling source file C:\Projects\WebKit2\OpenSource\Source\WebCore\inspector\InspectorAllInOne.cpp)

This happens because the file InspectorProtocolObjects.h exists in both folders, and #pragma once will not prevent us from including both files.

An include of the type <inspector/InspectorProtocolObjects.h> will include the file from the inspector folder, while <JavaScriptCore/InspectorProtocolObjects.h> will include the file from the JavaScriptCore folder.

This can be fixed by putting the WebCore forwarding folder first in the include list. This means that <inspector/InspectorProtocolObjects.h> will also include the file in the JavaScriptCore folder.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160916/4fbdf421/attachment.html>