[Webkit-unassigned] [Bug 162041] AX: Add accessibility support for details element on iOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162041

--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 289013
  --> https://bugs.webkit.org/attachment.cgi?id=289013
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289013&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1840
> +    for (AccessibilityObject* parent = object; parent; parent = parent->parentObject()) {

can we make a function that takes a lambda for running up the parent chain and returning a match object?
and then replace all such places with that ?

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1871
> +            // webkit.org/b/162041 Taking focus onto elements inside a details node will cause VO focusing onto random items.

why is this the case?
should we put this check inside canSetFocusAttribute() instead

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160916/1ca03232/attachment.html>