[Webkit-unassigned] [Bug 162006] New: There is no good reason for WeakBlock to care about newly allocated objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162006

            Bug ID: 162006
           Summary: There is no good reason for WeakBlock to care about
                    newly allocated objects
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fpizlo at apple.com

WeakBlock scans itself in two modes:

visit: if a Weak in the block belongs to an unmarked object, ask the Weak to consider whether it should do things.
reap: if a Weak in a block belongs to an unmarked object, delete the Weak.

Except that "unmarked" has a peculiar meaning: WeakBlock defines it as !markedOrNewlyAllocated.  So, a newly allocated object will never be consulted about anything.  That sounds scary until you realize that newlyAllocated must have been cleared before we even got here.

So, we were paying the price of checking newlyAllocated for no reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160915/6652c36e/attachment.html>