[Webkit-unassigned] [Bug 161394] AX: WKWebView for macOS does not allow configuration of tabsToLinks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161394

Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bburg at apple.com

--- Comment #7 from Brian Burg <bburg at apple.com> ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > I think this is more of a preference than a WKWebView property. The same
> > > property is available in WebPreferences for WebView control, so it makes
> > > sense to me to add in WKPreferences. Most of the properties on WKWebView
> > > change their state based on the web page contents loaded in the control,
> > > which is not the case with tabsToLinks. There is not a
> > > WKWebViewConfiguration equivalent of WebView to base the location on (some
> > > properties on WebPreferences for WebView have moved to
> > > WKWebViewConfiguration), but you also find this option as a preference in
> > > Safari. The user may want to configure it based on the WKWebView application.
> > 
> > After talking to some of my fellow colleagues, I tend to agree -
> > WKPreferences is intended to be used for "things you might want to show in a
> > preferences window", and "tabs to links" is one of the Safari preferences.
> > 
> > That said, I think we can come up with a better name than "tabsToLinks". It
> > sounds like  it converts tabs into links.
> 
> 
> I was keeping consistency with what is exposed in WebPreferences. Have there
> been other name changes between WebView and WKWebView for similar
> properties? I could call it tabNavigatesToLinks or linkTabStopEnabled

tabNavigatesToLinks sounds better to me.

Anders, is there anything else holding up review of this patch aside from the renaming?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160910/c17161dc/attachment-0001.html>