[Webkit-unassigned] [Bug 161409] [JSC] Implement parsing of Async Functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161409

--- Comment #20 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
(In reply to comment #19)
> Comment on attachment 288384 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288384&action=review
> 
> Could you hide async / await parsing feature behind compile time / run time
> flag?

I'll get around to addressing the review comments on Monday. But, before I leave this for the weekend, question re: your overall comments.

1) If using the compile-time flag option, is there any way I can keep tests added in this patch running and passing? I haven't really found a way to do this.

2) If a runtime flag approach is used, I don't think the runtime flag approach from the other bug is a good way to go, since it means adding flags all over the place when it's not realistically needed. A single global boolean in runtime/Options.cpp would probably make more sense, and would avoid changes all over the place for storing parser flags in various places where the parser might need to be entered again. Does that seem reasonable, or is the RuntimeFlags class the absolute preferred way to go?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160909/6a00122a/attachment-0001.html>