[Webkit-unassigned] [Bug 161803] New: Web Inspector: combine-resources.pl should support multiple transformations in one invocation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 9 10:26:11 PDT 2016


            Bug ID: 161803
           Summary: Web Inspector: combine-resources.pl should support
                    multiple transformations in one invocation
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bburg at apple.com
                CC: bburg at apple.com, joepeck at webkit.org,
                    mattbaker at apple.com, nvasilyev at apple.com,
                    timothy at apple.com, webkit-bug-importer at group.apple.com

In the interest of moving more of the WebInspectorUI build into Derived Sources-style phases, we need to have a clearer relationship between inputs and outputs. Currently, combine-resources.pl is called multiple times, using the same files (Main.html, etc) as both inputs and outputs. This is fundamentally incompatible with dependency-based build systems, and makes it difficult to debug problems along the way.

I think it would be better to make combine-resources.pl a bit less flexible and instead codify the conventions we have been using. In particular,

 * hard-code a list of targets to be concatenated or stripped, loosely based on folders. This would be the set {Inspector, Debug, Workers, CodeMirror, Esprima, ESLint}
 * each target has a hardcoded file pattern (such as 'External/Esprima')
 * output filenames are determined based on the target name plus a suffix
 * take arguments such as --combine=Inspector --combine=CodeMirror --strip=Debug --suffix=Combined

This will reduce the number of invocations to one per main resource in copy-user-interface-resources.pl and make it possible to move this step into Derived Sources easily.

There are still plenty of post-processing steps such as running minifiers and remove-console-asserts.pl. We can combine/streamline that stuff in a separate bug.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160909/182b67fb/attachment.html>

More information about the webkit-unassigned mailing list