[Webkit-unassigned] [Bug 161605] [GTK] Crash of WebProcess on the last WebView disconnect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161605

--- Comment #16 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #15)
> Comment on attachment 288115 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288115&action=review
> 
> rs=me for 2.14, but I prefer just removing the code in trunk.

Agree.

> > Source/WebCore/ChangeLog:13
> > +        pointer ownership. Since this is specific to GLX, I've moed the code from GLContext to GLContextGLX and
> 
> moved
> 
> > Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:209
> > +    clear();
> > +    activeContexts().remove(this);
> 
> Good idea.
> 
> > Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:225
> > +    glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, 0);
> > +    glXMakeCurrent(downcast<PlatformDisplayX11>(m_display).native(), None, None);
> 
> Is this new?

No, it was in the destructor and now in clear().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160907/ded8e829/attachment-0001.html>