[Webkit-unassigned] [Bug 161506] [iOS] input pattern="[0-9.]*" should use DecimalPad keyboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161506

--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 287932
  --> https://bugs.webkit.org/attachment.cgi?id=287932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287932&action=review

I like this idea.  Can this be tested?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2517
> +static const char inputPatternNumber[] = "^(\\[0-9\\]|\\\\d)(\\+|\\*|\\{[0-9,]+\\})?$";
> +static const char inputPatternDecimal[] = "^(\\[0-9\\]|\\\\d)?(\\+|\\*|\\{[0-9,]+\\})?\\\\\\.(\\[0-9\\]|\\\\d)(\\+|\\*|\\{[0-9,]+\\})?$";

This is clever, but matching regular expressions with regular expressions seems like a step in the wrong direction.  We were doing string comparison before, which wasn't the greatest, but could we at least continue to do string comparison?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160906/9195d737/attachment.html>