[Webkit-unassigned] [Bug 164061] [GTK] Initial implementation of JavaScriptCore glib bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164061

--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 293040
  --> https://bugs.webkit.org/attachment.cgi?id=293040
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293040&action=review

Just a few initial observations:

> Source/JavaScriptCore/API/glib/JSCBoolean.cpp:40
> +jsc_boolean_class_init(JSCBooleanClass *)

Keep in mind that you need to follow WebKit coding style in the implementation files:

static void jscBooleanClassInit(JSCBooleanClass*)

The only exception is that API functions of course have to use underscores.

> Source/JavaScriptCore/API/glib/JSCBoolean.cpp:70
> +jsc_boolean_new(JSCContext *context, gboolean value)

You really can't do anything in these _new functions except call g_object_new, since the _new functions aren't exposed to introspection, the code will never be called from bindings. You want to make sure g_object_new works properly anyway. So everything needs to move to either _init or _constructed.

> Source/cmake/OptionsGTK.cmake:88
> +WEBKIT_OPTION_DEFINE(ENABLE_JSC_GLIB "Whether to enable support for JavaScriptCore glib bindings." PUBLIC OFF)

It should be alphabetized.

> Tools/Scripts/webkitpy/style/checker_unittest.py:289
> +           os.path.join('Source', 'JavaScriptCore', 'API', 'glib', 'JSCBoolean.h'),

This is just a unit test to make sure the style checker works, you shouldn't be modifying it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161027/8329af74/attachment.html>