[Webkit-unassigned] [Bug 164001] Add support for wide gamut for ShareableBitmap for image popovers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164001

--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 292867
  --> https://bugs.webkit.org/attachment.cgi?id=292867
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292867&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:101
> +    // Don't worry about extended colors on windows

This is not a "don't worry", this is a "if it doesn't have support, fall back to device". I also think it should probably fall back to sRGB, not device (if we have sRGB support but not extended, this one should use sRGB, not "device").

> Source/WebKit2/Shared/ShareableBitmap.cpp:41
> +        if (screenSupportsExtendedColor())

What Simon said before: this shouldn't depend on the screen. If wants extended color, it gets extended color.

> Source/WebKit2/Shared/ShareableBitmap.h:130
> +    // FIXME: make sure this is ok, this seems to be windows thing, maybe??

Get rid of the comment and solve it one way or the other :) Take a peek at ShareableBitmapCairo:

return Checked<unsigned, RecordOverflow>(cairo_format_stride_for_width(cairoFormat, size.width())) * size.height();

So I think you're OK.

> Source/WebKit2/Shared/cg/ShareableBitmapCG.cpp:67
> +    if ((m_flags & ShareableBitmap::SupportsExtendedColor) && (screenSupportsExtendedColor()))

No need for the parens around the function call at the end.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161026/619fad21/attachment-0001.html>