[Webkit-unassigned] [Bug 163777] NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 21 22:50:59 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=163777

--- Comment #10 from Keith Rollin <krollin at apple.com> ---
Created attachment 292471
  --> https://bugs.webkit.org/attachment.cgi?id=292471&action=review
Patch to be applied after the main patch

The attached patch should be applied after applying the patch in comment #4. This patch, however, might need a few tweaks before being acceptable for inclusion in the main patch:

* The change to NetworkDataTaskCocoa.h was meant merely to get the build to work. It's possible that the final change would be to move the affected private functions into the public section.

* The downcast<>() in NetworkDataTaskCocoa.mm was changed to a reinterpret_cast<>(). The downcast<>() wasn't working and I didn't know enough about that facility to get it to work. A real solution might to be get downcast<>() to work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161022/e48465b0/attachment-0001.html>


More information about the webkit-unassigned mailing list