[Webkit-unassigned] [Bug 163721] Style resolver should be updated lazily

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163721

--- Comment #14 from Antti Koivisto <koivisto at iki.fi> ---
> IIUC this is needed for hasPendingForcedStyleRecalc() to work correctly. Is
> that accurate? If so, do we also need to do this in
> Element::needsStyleInvalidation()?

No because needsStyleInvalidation() is used to avoid invalidation work when we know we are already invalidated. Calling flushPendingUpdates() would catch more cases like that but it is way more expensive than per-element work that needsStyleInvalidation() is trying to optimize.

> 
> > Source/WebCore/testing/Internals.cpp:385
> > +    page.group().captionPreferences().setTestingMode(true);
> 
> This deserves a ChangeLog comment at least. :P

Yea. It is about avoiding inserting magical caption UA sheet that screws up some inspector tests. The existing code that was avoiding that was racy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161020/30bfc7d7/attachment.html>