[Webkit-unassigned] [Bug 163575] check-webkit-style: fix false-positive warnings about using #pragma once header guard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163575

--- Comment #5 from Brady Eidson <beidson at apple.com> ---
(In reply to comment #3)
> > Headers without guards are clearly okay (as if they weren't okay then the
> > builds would be failing)
> 
> It would be nice to detect and warn when a header is missing header guards
> that _should_ have header guards. A build may succeed if its missing, but
> later when someone else double includes the header it could fail.

Yah, I guess that was the unspoken subtext of what I meant.

I also am not sure what the actual compiler error is when you double include a header - Whether it's unintelligible random errors, or if the compiler explicitly points it out.

In the later case, I think it'd be fine to just ignore it until an error pops up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161019/6542529b/attachment.html>