[Webkit-unassigned] [Bug 163610] AX: [Mac] Meter element should use AXValueDescription to descrbe the status of the value

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 18 18:22:45 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=163610

--- Comment #8 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 291982
  --> https://bugs.webkit.org/attachment.cgi?id=291982
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291982&action=review

>>>> Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp:175
>>>> +    if (!m_renderer || !m_renderer->isMeter())
>>> 
>>> why do we only want this on COCOA? (does COCOA also mean iOS?)
>> 
>> Because the localized string is in cocoa, I followed other mac only descriptions. I think it's both mac and iOS. But Meter is not currently supported on iOS. Should we wrap with platform(mac)?
> 
> I think the #if FEATURE(METER) flag would handle that. so maybe we use COCOA and METER

This #if PLATFORM(COCOA) is already in the #if ENABLE(METER_ELEMENT) wrap

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161019/fd4211a4/attachment-0001.html>


More information about the webkit-unassigned mailing list