[Webkit-unassigned] [Bug 163610] AX: [Mac] Meter element should use AXValueDescription to descrbe the status of the value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163610

--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 291976
  --> https://bugs.webkit.org/attachment.cgi?id=291976
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291976&action=review

> Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp:176
> +    // Only expose this when the author has explicitly specified following attributes.

specified "the" following

> Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp:184
> +            description = "optimum";

I think we can return directly from this switch statement instead of setting a value

> Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp:190
> +            description = "less good";

I think either this method should return the enum or it should return the localized string itself

right now it returns an intermediary form which still needs to be processed further

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161018/9f28079d/attachment.html>