[Webkit-unassigned] [Bug 163579] New: [JSC] investigate reason for `hasProperty()` calls used to reify non-lazy properties in in JSFunction::put()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163579

            Bug ID: 163579
           Summary: [JSC] investigate reason for `hasProperty()` calls
                    used to reify non-lazy properties in in
                    JSFunction::put()
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: caitp at igalia.com

The following code in Source/JavaScriptCore/runtime/JSFunction.cpp, added in 2011, could use some investigation/auditing:

```
        // This will trigger the property to be reified, if this is not already the case!
         bool okay = thisObject->hasProperty(exec, propertyName);
         ASSERT_UNUSED(okay, okay);
         scope.release();
         return Base::put(thisObject, exec, propertyName, value, slot);
```

It's unclear what the purpose of reifying this is, as the properties in question are not lazy. Base::put() ought to be enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161018/902b8cea/attachment.html>