[Webkit-unassigned] [Bug 163470] run-webkit-tests consumes gigabytes of memory with --iterations 4294967300

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 14 16:55:34 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=163470

--- Comment #2 from Dean Johnson <dean_johnson at apple.com> ---
I would suspect the major issue here being this function:

OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
...
class Manager(object):
...
    def _get_test_inputs(self, tests_to_run, repeat_each, iterations):
        test_inputs = []
        for _ in xrange(iterations):
            for test in tests_to_run:
                for _ in xrange(repeat_each):
                    test_inputs.append(self._test_input_for_file(test)) # This line
        return test_inputs

Since it figures out all test_inputs before the tests are actually ran, you'll see multiple gigabytes of data stored in memory with large iteration numbers.

Is this really an issue? When do we ever run millions of iterations? If we do need to do this for some reason, can we limit it to 1000000?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161014/53b92ddf/attachment.html>


More information about the webkit-unassigned mailing list