[Webkit-unassigned] [Bug 161450] No reliable way to get a snapshot of WKWebView (macOS)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161450

--- Comment #26 from Dan Saunders <dasau at microsoft.com> ---
(In reply to comment #14)
> I think we need significantly more test coverage. The single test is better
> than nothing, but I’d like to see tests covering different types of content.

I can look into adding additional tests. The problem with any test that is testing WebKit pixel contents is it is likely to unreliable when the rendering changes slightly. I see TestInvocation::dumpPixelsAndCompareWithExpected is already used in the test, perhaps this has been unreliable in the past. I don't want to make maintaining the test to be too much overhead. For Mac we are just calling into WebPage::takeSnapshot which is used to take a snapshot in other places such as thumbnails. The thumbnail tests do not compare pixel content and are more basic to be reliable. My unit tests are testing the code I added is functioning, but not testing all the edge cases of WebPage::takeSnapshot specifically. I am testing that I can retrieve a pixel that should deterministically be a certain color. WebPage::takeSnapshot should be reliable because it is used for core functionality of WebKit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161014/292169f6/attachment.html>