[Webkit-unassigned] [Bug 161450] No reliable way to get a snapshot of WKWebView (macOS)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161450

--- Comment #22 from Tim Horton <thorton at apple.com> ---
(In reply to comment #21)
> Thanks for the responses. It seems like there is not another option that is
> currently available other than to use the asynchronous software snapshot on
> Mac. Tim, are you ok with adding this new API that uses the software
> snapshot.

I think it's fine, for now. I still need to talk to Anders about how to make progress with adding new API, but the software-paint mechanism is probably good enough for now, and we can improve as things get better, as you say; the API doesn't tie us to a particular implementation.

In the meantime, can you address Darin's other comments?

> I believe there is a way to do this without all these typecast casts to the block type, perhaps by using the equivalence of blocks and lambdas.

> I think we need significantly more test coverage. The single test is better than nothing, but I’d like to see tests covering different types of content.

Also, I wonder if it is more appropriate for a modern ObjC API to return ObjC types (NSImage and UIImage) instead of CGImageRef.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161013/3862896b/attachment.html>