[Webkit-unassigned] [Bug 155955] border-image-repeat:round output doesn't match other browsers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 14:01:58 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=155955

--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Please do. I started looking at this and it's a bit more involved than I thought.

Basically I think the fix should reflect this comment in Image::drawTiled():
    // FIXME: These rules follow CSS border-image rules, but they should not be down here in Image.

so the 'space' and 'round' logic there needs to pushed up into NinePieceImage::computeTileScales(), maybe as part of scaleSlicesIfNeeded(). This probably requires sending 'spacing' and 'phase' down through GraphicsContext::drawTiledImage(). I think this code move is necessary to implement this part of the spec:

"The middle image's width is scaled by the same factor as the top image unless that factor is zero or infinity, in which case the scaling factor of the bottom is substituted, and failing that, the width is not scaled. The height of the middle image is scaled by the same factor as the left image unless that factor is zero or infinity, in which case the scaling factor of the right image is substituted, and failing that, the height is not scaled."

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161012/f7e7a2c2/attachment.html>


More information about the webkit-unassigned mailing list