[Webkit-unassigned] [Bug 163346] [GTK] trunk r207192 fails to compile WebTextChecker* due to missing definition of WKTextCheckerClientBase

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 13:57:59 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=163346

--- Comment #1 from Jonathan Bedard <jbedard at apple.com> ---
What is the build configuration?

Bug #163340 adds access for the TextChecker for testing, which should be in a file named WKTextChecker.h.  What existed in WKTextChecker.h at the time should really be in a file named WKWebTextChecker.h, but renaming this file would be changing API.  WKTextChecker as of bug #163340 is essentially a combination of the two headers.  It breaks convention to preserve API.

In all of our builds, WebTextChecker is never used on Apple's systems, and this is the reason for the defined(__APPLE__).  I'm curious what you're doing to build WebTextChecker while on a system which would, at least to my understanding, usually not support it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161012/46136312/attachment.html>


More information about the webkit-unassigned mailing list