[Webkit-unassigned] [Bug 163232] Stop copying author shadow pseudo rules into shadow tree style resolver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163232

--- Comment #7 from Antti Koivisto <koivisto at iki.fi> ---
> What guarantees this is non-null?

The call site tests we are in a shadow tree. Added an assert.

> What guarantees shadowRoot.host() is non-null?

We should never be resolving style for a disconnected shadow tree.

> Anders and I would write this in this new coding style:
> 
>     MatchRequest hostAuthorRequest { &hostAuthorRules,
> matchRequest.includeEmptyRules };
> 
> Has the benefit of not looking anything like a function call and another
> benefit is that it won’t do implicit type conversions like silently
> converting an int to a boolean.

I'm not sure I understand the first point. Invoking a constructor is a function call so looking like one doesn't seem so wrong to me.

> What guarantees ruleSet is non-null?

Call sites assert or set it explicitly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161011/9bb8a85b/attachment.html>