[Webkit-unassigned] [Bug 163186] New: REGRESSION(r192992): [GTK] Layout test editing/pasteboard/onpaste-text-html.html failing with whitespace changes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 9 13:47:36 PDT 2016
https://bugs.webkit.org/show_bug.cgi?id=163186
Bug ID: 163186
Summary: REGRESSION(r192992): [GTK] Layout test
editing/pasteboard/onpaste-text-html.html failing with
whitespace changes
Classification: Unclassified
Product: WebKit
Version: Other
Hardware: PC
OS: Linux
Status: NEW
Severity: Normal
Priority: P2
Component: WebKit Gtk
Assignee: webkit-unassigned at lists.webkit.org
Reporter: mcatanzaro at igalia.com
CC: bugs-noreply at webkitgtk.org, mmaxfield at apple.com
This is a strange one. Layout test editing/pasteboard/onpaste-text-html.html is failing on GTK since either r192992 "Unify font-variant-* with font-variant shorthand" or r192993 (a JSC change, not likely related). Thing is, the output looks identical, the only difference is that the characters used to make the whitespace changed:
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/onpaste-text-html-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/pasteboard/onpaste-text-html-actual.txt
@@ -1,6 +1,6 @@
CONSOLE MESSAGE: line 21: text/plain: This test verifies that we can get text/html from the clipboard during an onpaste event.
-CONSOLE MESSAGE: line 23: text/html: <span style="color: rgb(0, 0, 0); font-size: medium; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; display: inline !important; float: none;">This test verifies that we can get text/html from the clipboard during an onpaste event.<span class="Apple-converted-space"> </span></span>
+CONSOLE MESSAGE: line 23: text/html: <span style="color: rgb(0, 0, 0); font-size: medium; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; display: inline !important; float: none;">This test verifies that we can get text/html from the clipboard during an onpaste event.<span class="Apple-converted-space"> </span></span>
This test verifies that we can get text/html from the clipboard during an onpaste event. This test requires DRT.
-Paste content in this div.This test verifies that we can get text/html from the clipboard during an onpaste event.
+Paste content in this div.This test verifies that we can get text/html from the clipboard during an onpaste event.
PASS
You have to pipe the expected/actual results into xxd to see the differences. The space used in <span class="Apple-converted-space"> </span> was previously U+0020 (space) but is now two bytes c2 a0. U+00A0 is no-break space, U+00C2 must be something I don't understand since it's a printable character but it's not displayed at all.
So, the question is: is this whitespace change expected? Can we just change the expected results of the test? Or is something broken?
$ cat onpaste-text-html-expected.txt | xxd
00000000: 434f 4e53 4f4c 4520 4d45 5353 4147 453a CONSOLE MESSAGE:
00000010: 206c 696e 6520 3231 3a20 7465 7874 2f70 line 21: text/p
00000020: 6c61 696e 3a20 5468 6973 2074 6573 7420 lain: This test
00000030: 7665 7269 6669 6573 2074 6861 7420 7765 verifies that we
00000040: 2063 616e 2067 6574 2074 6578 742f 6874 can get text/ht
00000050: 6d6c 2066 726f 6d20 7468 6520 636c 6970 ml from the clip
00000060: 626f 6172 6420 6475 7269 6e67 2061 6e20 board during an
00000070: 6f6e 7061 7374 6520 6576 656e 742e 200a onpaste event. .
00000080: 434f 4e53 4f4c 4520 4d45 5353 4147 453a CONSOLE MESSAGE:
00000090: 206c 696e 6520 3233 3a20 7465 7874 2f68 line 23: text/h
000000a0: 746d 6c3a 203c 7370 616e 2073 7479 6c65 tml: <span style
000000b0: 3d22 636f 6c6f 723a 2072 6762 2830 2c20 ="color: rgb(0,
000000c0: 302c 2030 293b 2066 6f6e 742d 7369 7a65 0, 0); font-size
000000d0: 3a20 6d65 6469 756d 3b20 666f 6e74 2d73 : medium; font-s
000000e0: 7479 6c65 3a20 6e6f 726d 616c 3b20 666f tyle: normal; fo
000000f0: 6e74 2d76 6172 6961 6e74 2d63 6170 733a nt-variant-caps:
00000100: 206e 6f72 6d61 6c3b 2066 6f6e 742d 7765 normal; font-we
00000110: 6967 6874 3a20 6e6f 726d 616c 3b20 6c65 ight: normal; le
00000120: 7474 6572 2d73 7061 6369 6e67 3a20 6e6f tter-spacing: no
00000130: 726d 616c 3b20 6f72 7068 616e 733a 2061 rmal; orphans: a
00000140: 7574 6f3b 2074 6578 742d 616c 6967 6e3a uto; text-align:
00000150: 2073 7461 7274 3b20 7465 7874 2d69 6e64 start; text-ind
00000160: 656e 743a 2030 7078 3b20 7465 7874 2d74 ent: 0px; text-t
00000170: 7261 6e73 666f 726d 3a20 6e6f 6e65 3b20 ransform: none;
00000180: 7768 6974 652d 7370 6163 653a 206e 6f72 white-space: nor
00000190: 6d61 6c3b 2077 6964 6f77 733a 2061 7574 mal; widows: aut
000001a0: 6f3b 2077 6f72 642d 7370 6163 696e 673a o; word-spacing:
000001b0: 2030 7078 3b20 2d77 6562 6b69 742d 7461 0px; -webkit-ta
000001c0: 702d 6869 6768 6c69 6768 742d 636f 6c6f p-highlight-colo
000001d0: 723a 2072 6762 6128 302c 2030 2c20 302c r: rgba(0, 0, 0,
000001e0: 2030 2e34 293b 202d 7765 626b 6974 2d74 0.4); -webkit-t
000001f0: 6578 742d 7374 726f 6b65 2d77 6964 7468 ext-stroke-width
00000200: 3a20 3070 783b 2064 6973 706c 6179 3a20 : 0px; display:
00000210: 696e 6c69 6e65 2021 696d 706f 7274 616e inline !importan
00000220: 743b 2066 6c6f 6174 3a20 6e6f 6e65 3b22 t; float: none;"
00000230: 3e54 6869 7320 7465 7374 2076 6572 6966 >This test verif
00000240: 6965 7320 7468 6174 2077 6520 6361 6e20 ies that we can
00000250: 6765 7420 7465 7874 2f68 746d 6c20 6672 get text/html fr
00000260: 6f6d 2074 6865 2063 6c69 7062 6f61 7264 om the clipboard
00000270: 2064 7572 696e 6720 616e 206f 6e70 6173 during an onpas
00000280: 7465 2065 7665 6e74 2e3c 7370 616e 2063 te event.<span c
00000290: 6c61 7373 3d22 4170 706c 652d 636f 6e76 lass="Apple-conv
000002a0: 6572 7465 642d 7370 6163 6522 3e20 3c2f erted-space"> </
000002b0: 7370 616e 3e3c 2f73 7061 6e3e 0a54 6869 span></span>.Thi
000002c0: 7320 7465 7374 2076 6572 6966 6965 7320 s test verifies
000002d0: 7468 6174 2077 6520 6361 6e20 6765 7420 that we can get
000002e0: 7465 7874 2f68 746d 6c20 6672 6f6d 2074 text/html from t
000002f0: 6865 2063 6c69 7062 6f61 7264 2064 7572 he clipboard dur
00000300: 696e 6720 616e 206f 6e70 6173 7465 2065 ing an onpaste e
00000310: 7665 6e74 2e20 5468 6973 2074 6573 7420 vent. This test
00000320: 7265 7175 6972 6573 2044 5254 2e0a 5061 requires DRT..Pa
00000330: 7374 6520 636f 6e74 656e 7420 696e 2074 ste content in t
00000340: 6869 7320 6469 762e 5468 6973 2074 6573 his div.This tes
00000350: 7420 7665 7269 6669 6573 2074 6861 7420 t verifies that
00000360: 7765 2063 616e 2067 6574 2074 6578 742f we can get text/
00000370: 6874 6d6c 2066 726f 6d20 7468 6520 636c html from the cl
00000380: 6970 626f 6172 6420 6475 7269 6e67 2061 ipboard during a
00000390: 6e20 6f6e 7061 7374 6520 6576 656e 742e n onpaste event.
000003a0: 200a 5041 5353 0a0a .PASS..
$ cat onpaste-text-html-actual.txt | xxd
00000000: 434f 4e53 4f4c 4520 4d45 5353 4147 453a CONSOLE MESSAGE:
00000010: 206c 696e 6520 3231 3a20 7465 7874 2f70 line 21: text/p
00000020: 6c61 696e 3a20 5468 6973 2074 6573 7420 lain: This test
00000030: 7665 7269 6669 6573 2074 6861 7420 7765 verifies that we
00000040: 2063 616e 2067 6574 2074 6578 742f 6874 can get text/ht
00000050: 6d6c 2066 726f 6d20 7468 6520 636c 6970 ml from the clip
00000060: 626f 6172 6420 6475 7269 6e67 2061 6e20 board during an
00000070: 6f6e 7061 7374 6520 6576 656e 742e 200a onpaste event. .
00000080: 434f 4e53 4f4c 4520 4d45 5353 4147 453a CONSOLE MESSAGE:
00000090: 206c 696e 6520 3233 3a20 7465 7874 2f68 line 23: text/h
000000a0: 746d 6c3a 203c 7370 616e 2073 7479 6c65 tml: <span style
000000b0: 3d22 636f 6c6f 723a 2072 6762 2830 2c20 ="color: rgb(0,
000000c0: 302c 2030 293b 2066 6f6e 742d 7369 7a65 0, 0); font-size
000000d0: 3a20 6d65 6469 756d 3b20 666f 6e74 2d73 : medium; font-s
000000e0: 7479 6c65 3a20 6e6f 726d 616c 3b20 666f tyle: normal; fo
000000f0: 6e74 2d76 6172 6961 6e74 2d63 6170 733a nt-variant-caps:
00000100: 206e 6f72 6d61 6c3b 2066 6f6e 742d 7765 normal; font-we
00000110: 6967 6874 3a20 6e6f 726d 616c 3b20 6c65 ight: normal; le
00000120: 7474 6572 2d73 7061 6369 6e67 3a20 6e6f tter-spacing: no
00000130: 726d 616c 3b20 6f72 7068 616e 733a 2061 rmal; orphans: a
00000140: 7574 6f3b 2074 6578 742d 616c 6967 6e3a uto; text-align:
00000150: 2073 7461 7274 3b20 7465 7874 2d69 6e64 start; text-ind
00000160: 656e 743a 2030 7078 3b20 7465 7874 2d74 ent: 0px; text-t
00000170: 7261 6e73 666f 726d 3a20 6e6f 6e65 3b20 ransform: none;
00000180: 7768 6974 652d 7370 6163 653a 206e 6f72 white-space: nor
00000190: 6d61 6c3b 2077 6964 6f77 733a 2061 7574 mal; widows: aut
000001a0: 6f3b 2077 6f72 642d 7370 6163 696e 673a o; word-spacing:
000001b0: 2030 7078 3b20 2d77 6562 6b69 742d 7461 0px; -webkit-ta
000001c0: 702d 6869 6768 6c69 6768 742d 636f 6c6f p-highlight-colo
000001d0: 723a 2072 6762 6128 302c 2030 2c20 302c r: rgba(0, 0, 0,
000001e0: 2030 2e34 293b 202d 7765 626b 6974 2d74 0.4); -webkit-t
000001f0: 6578 742d 7374 726f 6b65 2d77 6964 7468 ext-stroke-width
00000200: 3a20 3070 783b 2064 6973 706c 6179 3a20 : 0px; display:
00000210: 696e 6c69 6e65 2021 696d 706f 7274 616e inline !importan
00000220: 743b 2066 6c6f 6174 3a20 6e6f 6e65 3b22 t; float: none;"
00000230: 3e54 6869 7320 7465 7374 2076 6572 6966 >This test verif
00000240: 6965 7320 7468 6174 2077 6520 6361 6e20 ies that we can
00000250: 6765 7420 7465 7874 2f68 746d 6c20 6672 get text/html fr
00000260: 6f6d 2074 6865 2063 6c69 7062 6f61 7264 om the clipboard
00000270: 2064 7572 696e 6720 616e 206f 6e70 6173 during an onpas
00000280: 7465 2065 7665 6e74 2e3c 7370 616e 2063 te event.<span c
00000290: 6c61 7373 3d22 4170 706c 652d 636f 6e76 lass="Apple-conv
000002a0: 6572 7465 642d 7370 6163 6522 3ec2 a03c erted-space">..<
000002b0: 2f73 7061 6e3e 3c2f 7370 616e 3e0a 5468 /span></span>.Th
000002c0: 6973 2074 6573 7420 7665 7269 6669 6573 is test verifies
000002d0: 2074 6861 7420 7765 2063 616e 2067 6574 that we can get
000002e0: 2074 6578 742f 6874 6d6c 2066 726f 6d20 text/html from
000002f0: 7468 6520 636c 6970 626f 6172 6420 6475 the clipboard du
00000300: 7269 6e67 2061 6e20 6f6e 7061 7374 6520 ring an onpaste
00000310: 6576 656e 742e 2054 6869 7320 7465 7374 event. This test
00000320: 2072 6571 7569 7265 7320 4452 542e 0a50 requires DRT..P
00000330: 6173 7465 2063 6f6e 7465 6e74 2069 6e20 aste content in
00000340: 7468 6973 2064 6976 2e54 6869 7320 7465 this div.This te
00000350: 7374 2076 6572 6966 6965 7320 7468 6174 st verifies that
00000360: 2077 6520 6361 6e20 6765 7420 7465 7874 we can get text
00000370: 2f68 746d 6c20 6672 6f6d 2074 6865 2063 /html from the c
00000380: 6c69 7062 6f61 7264 2064 7572 696e 6720 lipboard during
00000390: 616e 206f 6e70 6173 7465 2065 7665 6e74 an onpaste event
000003a0: 2ec2 a00a 5041 5353 0a0a ....PASS..
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161009/bc9182f4/attachment-0001.html>
More information about the webkit-unassigned
mailing list