[Webkit-unassigned] [Bug 163011] [GTK] UIProcess crashes when using Japanese IM

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 7 09:43:31 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=163011

--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 290920
  --> https://bugs.webkit.org/attachment.cgi?id=290920
Fix review comments

View in context: https://bugs.webkit.org/attachment.cgi?id=290920&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:710
> +    priv->inputMethodFilter.filterKeyEvent(&event->key, [priv, event = WTFMove(event)](const WebCore::CompositionResults& compositionResults, InputMethodFilter::EventFakedForComposition faked) {

You can use event->key here, because even has already been moved to the lambda, use keyEvent instead.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:730
> +    priv->inputMethodFilter.filterKeyEvent(&event->key, [priv, event = WTFMove(event)](const WebCore::CompositionResults& compositionResults, InputMethodFilter::EventFakedForComposition faked) {

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161007/e51f6688/attachment.html>


More information about the webkit-unassigned mailing list