[Webkit-unassigned] [Bug 162913] [GTK][EFL] CryptoDigest implementation depends on GnuTLS with LGPLv3+/GPLv2+ deps

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162913

--- Comment #5 from Olivier Blin <olivier.blin at softathome.com> ---
(In reply to comment #4)

> Perhaps the SubtleCrypto code can be replace with a libgcrypt
> implementation. 
>
> And then the code for CSP code can use the hash functions from SubtleCrypto
> if this was selected at build time. Otherwise it can fall back to our
> simple/non-optimized internal implementations of sha-1/sha-2.

CSP is using CryptoDigest directly.
Maybe the CryptoAlgorithmHMAC platform-specific implementations in Source/WebCore/crypto should be replaced by a common implementation that uses CryptoDigest.
This is what is done in Source/WebCore/crypto/algorithms/ implementations already.

By the way, it looks a bit weird to have platform specific implementations of crypto in both and Source/WebCore/crypto/<platform> (SubtleCrypto) and Source/WebCore/platform/crypto/<platform>/ (CryptoDigest)

I am going to propose both a libgcrypt implementation and an OpenSSL implmentation of CryptoDigest.

Another alternative would be to resurrect the gcrypt backend in gnutls, since performance improved since its removal (nettle was preferred at the time).
See https://www.gnupg.org/blog/20131215-gcrypt-bench.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161005/ec1609cd/attachment.html>