[Webkit-unassigned] [Bug 162910] [SOUP] Move global TLS errors handling from ResourceHandle to SoupNetworkSession

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162910

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290695|review?                     |review+
              Flags|                            |

--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 290695
  --> https://bugs.webkit.org/attachment.cgi?id=290695
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290695&action=review

Yep.  Moves the code.  Great.  r=me

> Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:80
> +        SHA1 sha1;

You should probably migrate away from SHA1, it being theoretically not cryptographically secure and all...

> Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:86
> -    ResourceHandle::setIgnoreSSLErrors(ignoreTLSErrors);
> +    SoupNetworkSession::setShouldIgnoreTLSErrors(ignoreTLSErrors);

It seems like we should work towards removing this, too.  Very bad things can happen when we ignore TLS errors.

> Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:91
> -    ResourceHandle::setClientCertificate(host, certificateInfo.certificate());
> +    SoupNetworkSession::allowSpecificHTTPSCertificateForHost(certificateInfo, host);

We are also moving away from allowing specific TLS certificates.  I'm going to do this on Cocoa by using SecTrustEvaluateAsync with a few additional checks in the NetworkProcess after receiving the server trust evaluation challenge.  This will avoid IPC and allow us to quickly and asynchronously connect to most HTTPS servers that use modern TLS and valid certificates.  In the case where it fails such as on badssl.com we will send IPC to the UIProcess which has the option of responding and saying to trust the server even though it's probably unsafe.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161005/a531ba66/attachment.html>