[Webkit-unassigned] [Bug 162124] Unite op_get_by_id_with_this with op_get_by_id

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162124

Caio Lima <ticaiolima at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289377|0                           |1
        is obsolete|                            |
 Attachment #290487|0                           |1
        is obsolete|                            |
 Attachment #289377|review?                     |
              Flags|                            |
 Attachment #290488|                            |review?
              Flags|                            |

--- Comment #17 from Caio Lima <ticaiolima at gmail.com> ---
Created attachment 290488
  --> https://bugs.webkit.org/attachment.cgi?id=290488&action=review
Patch

This patch is rebasing with master and removing some debug code that I left in the last one.

As a reference for performance gains, I ran "super-get-by-id-with-this-monomorphic" with and without getter IC for op_get_by_id versions without merging the op_get_by_id_this. The result:

baseline                  changes                                      

super-get-by-id-with-this-monomorphic       52.2877+-0.9619     ^     31.3060+-0.8299        ^ definitely 1.6702x faster

<geometric>                                 52.2877+-0.9619     ^     31.3060+-0.8299        ^ definitely 1.6702x faster

Also I ran for benchmarks with --benchmarks "getter" and got ~30-40x faster, but I didn't figure out why this big difference yet. What I did to disable Getter IC was change https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/jit/Repatch.cpp#L270 to ```return GivenUpOnCahe```.

The gains over ```super-get-by-id-with-this-monomorphic``` are explained because it uses self-getter to call the super-getter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161003/9afc1dfb/attachment-0001.html>