[Webkit-unassigned] [Bug 162862] New: Fix the USE(COORDINATED_GRAPHICS) build after r206712

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 3 03:00:54 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=162862

            Bug ID: 162862
           Summary: Fix the USE(COORDINATED_GRAPHICS) build after r206712
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Blocker
          Priority: P1
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ossy at webkit.org
                CC: cgarcia at igalia.com, clopez at igalia.com,
                    gyuyoung.kim at webkit.org, hs85.jeong at samsung.com,
                    simon.fraser at apple.com, zalan at apple.com

https://trac.webkit.org/changeset/206712 broke the USE(COORDINATED_GRAPHICS) build - EFL and GTK:
- https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/29947
- https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/73574

../../Source/WebCore/page/scrolling/ScrollingStateTree.cpp: In member function ‘WebCore::ScrollingNodeID WebCore::ScrollingStateTree::attachNode(WebCore::ScrollingNodeType, WebCore::ScrollingNodeID, WebCore::ScrollingNodeID)’:
../../Source/WebCore/page/scrolling/ScrollingStateTree.cpp:108:47: error: invalid use of incomplete type ‘class WebCore::AsyncScrollingCoordinator’
             newNodeID = m_scrollingCoordinator->uniqueScrollLayerID();
invalid use of incomplete type ‘class WebCore::AsyncScrollingCoordinator’
             newNodeID = m_scrollingCoordinator->uniqueScrollLayerID();

The problem is that AsyncScrollingCoordinator is a Mac only class guarded by ENABLE(ASYNC_SCROLLING).
m_scrollingCoordinator shouldn't be used anywhere without the same guard.

( note: I just reported the bug to let you know that the build is broken,
I don't have any plan and any time to work on the fix or help fixing. )

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161003/c4ab1bf3/attachment.html>


More information about the webkit-unassigned mailing list