[Webkit-unassigned] [Bug 165125] New: Avoid ref-count churn in ShadowParseContext::commitColor()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165125

            Bug ID: 165125
           Summary: Avoid ref-count churn in
                    ShadowParseContext::commitColor()
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Local Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: dbates at webkit.org
                CC: hyatt at apple.com, koivisto at iki.fi,
                    simon.fraser at apple.com

In ShadowParseContext::commitColor() we copy the committed color (a RefPtr<CSSPrimitiveValue>&&) into ShadowParseContext::color. Instead we should move it. This has the benefit of avoiding unnecessary ref-count churn. Also, ShadowParseContext::commitColor() should take a Ref<CSSPrimitiveValue>&& as it does not expect to be passed a nullptr for the committed color as far as I can tell.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161129/3861da39/attachment.html>