[Webkit-unassigned] [Bug 43239] Support for HTML Media Capture API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43239

--- Comment #40 from Andrew Gold <agold at apple.com> ---
(In reply to comment #32)
> Comment on attachment 295147 [details]
> Rebased patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295147&action=review
> 
> So much progress!
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:62
> > +- (void)_webView:(WKWebView *)webView checkUserMediaPermissionForURL:(NSURL *)url mainFrameURL:(NSURL *)mainFrameURL frameIdentifier:(NSUInteger)frameIdentifier decisionHandler:(void (^)(NSString *salt, BOOL authorized))decisionHandler WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> 
> What's up with the salt parameter?

It is the string we use to make sure capture device IDs are unique per domain.

> 
> > Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:351
> > +#if PLATFORM(IOS)
> 
> Likely we should have a function that does this work and implement it
> separately in e.g. new UIDelegateIOS and UIDelegateMac files, doing the
> different things, to satisfy Sam's comment above. There are also other
> things around that should be (separately) moved into something like that.

Filed: https://bugs.webkit.org/show_bug.cgi?id=165101

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161128/e459083e/attachment.html>