[Webkit-unassigned] [Bug 43239] Support for HTML Media Capture API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 18 14:08:23 PST 2016


Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
 Attachment #295147|review?                     |review+
              Flags|                            |

--- Comment #32 from Tim Horton <thorton at apple.com> ---
Comment on attachment 295147
  --> https://bugs.webkit.org/attachment.cgi?id=295147
Rebased patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=295147&action=review

So much progress!

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:62
> +- (void)_webView:(WKWebView *)webView checkUserMediaPermissionForURL:(NSURL *)url mainFrameURL:(NSURL *)mainFrameURL frameIdentifier:(NSUInteger)frameIdentifier decisionHandler:(void (^)(NSString *salt, BOOL authorized))decisionHandler WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

What's up with the salt parameter?

> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:351

Likely we should have a function that does this work and implement it separately in e.g. new UIDelegateIOS and UIDelegateMac files, doing the different things, to satisfy Sam's comment above. There are also other things around that should be (separately) moved into something like that.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161118/484dbdda/attachment-0001.html>

More information about the webkit-unassigned mailing list