[Webkit-unassigned] [Bug 164789] Implement WebPlaybackControlsManager

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 15 13:55:58 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=164789

WebKit Commit Bot <commit-queue at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |commit-queue at webkit.org

--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org> ---
Attachment 294876 did not pass style-queue:


ERROR: Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:108:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:242:  The parameter name "playing" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161115/1267dfbb/attachment-0001.html>


More information about the webkit-unassigned mailing list