[Webkit-unassigned] [Bug 164709] New: [GStreamer] video sink management improvements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164709

            Bug ID: 164709
           Summary: [GStreamer] video sink management improvements
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: pnormand at igalia.com
                CC: alex at igalia.com, calvaris at igalia.com,
                    cgarcia at igalia.com, pnormand at igalia.com

+++ This bug was initially created as a clone of Bug #164585 +++

Quoting Xabier:

"> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:343
> +    GstElement* sink;

This needs to be GRefPtr, why?

createGLAppSink and gst_bin_new return a floating ref.
g_object_get_ returns a hard ref.

I didn't dig into the code of g_object_new/set to know what happens with an object passed as argument to the constructor, if the ref is sinked or not, but g_object_get returns a hard ref so we need to change this.

I am going thru all this and even with this naïve code, the ref counting is incredibly hard to follow :) Not saying that is wrong or that there is another better way to do, just stating the fact, specially because OWR is undocumented and you have to check the code directly
"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161114/a2ad563a/attachment.html>