[Webkit-unassigned] [Bug 164364] Downloads started by context menu actions should also have a web view associated

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164364

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #293758|review?                     |review+
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 293758
  --> https://bugs.webkit.org/attachment.cgi?id=293758
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293758&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:1237
> +    return download.leakRef();

Where is this ref adopted? Normally we leave a comment in situations like this.

> Source/WebKit2/UIProcess/WebProcessPool.cpp:816
> +    if (initiatingPage)
> +        initiatingPage->handleDownloadRequest(downloadProxy);

We need an owner to approve this part. Alex?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161113/483f8e3a/attachment-0001.html>