[Webkit-unassigned] [Bug 164684] New: USE(APPLE_INTERNAL_SDK) should not be combined with other conditions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164684

            Bug ID: 164684
           Summary: USE(APPLE_INTERNAL_SDK) should not be combined with
                    other conditions
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mitz at webkit.org
                CC: bdakin at apple.com, sam at webkit.org

There are some instances of
    #if USE(APPLE_INTERNAL_SDK) && …
in the code base, but this is hardly ever the right thing to do. USE(APPLE_INTERNAL_SDK) really only makes sense as the innermost condition, and almost always has an #else clause that should not depend on anything other than the use of the internal SDK (but should just contain declarations that are equivalent to what the SDK provides).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161112/88eba247/attachment.html>