[Webkit-unassigned] [Bug 164610] Get touch bar code building for open source builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 10 13:18:10 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=164610

--- Comment #3 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 294400
  --> https://bugs.webkit.org/attachment.cgi?id=294400
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294400&action=review

> Source/WTF/wtf/Platform.h:1214
> +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101201

I don’t think this is quite right. When building with the 10.12.1 SDK but targeting earlier-than-10.12 deployment, the code for these capabilities should not be compiled. So you should also check that __MAC_OS_X_VERSION_MIN_REQUIRED is at least 101200.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161110/9a084767/attachment.html>


More information about the webkit-unassigned mailing list