[Webkit-unassigned] [Bug 164490] [Cocoa] Support wide gamut for Drag Image UI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164490

--- Comment #6 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 294116
  --> https://bugs.webkit.org/attachment.cgi?id=294116
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294116&action=review

> Source/WebCore/platform/graphics/mac/ImageMac.mm:141
> +    return adoptNS([[NSImage alloc] initWithCGImage:nativeImage.get() size:NSZeroSize]);

initWithCGImage returns an NSImage with NSImageRep of class NSCGImageSnapshotRep. On 2x display, it doubles the image size. Please see https://bugs.webkit.org/show_bug.cgi?id=162109#c32 and https://bugs.webkit.org/show_bug.cgi?id=162109#c34. Is this what you want?

> Source/WebCore/platform/mac/DragImageMac.mm:131
> +    auto dragImage = image->snapshotNSImage(DontCopyBackingStore);

I think this is going to break the API test: WebKit2.FindMatches. Make sure you pass all the API tests before landing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161109/5d95f69a/attachment.html>