[Webkit-unassigned] [Bug 43239] Support for HTML Media Capture API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43239

Andrew Gold <agold at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agold at apple.com

--- Comment #8 from Andrew Gold <agold at apple.com> ---
(In reply to comment #7)
> Comment on attachment 293962 [details]
> Proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=293962&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:67
> > +- (void)_webView:(WKWebView *)webVIew checkUserMediaPermissionForURL:(NSURL *)url mainFrameURL:(NSURL *)mainFrameURL frameIdentifier:(NSUInteger)frameIdentifier decisionHandler:(void (^)(NSString *salt, BOOL authorized))decisionHandler WK_API_AVAILABLE(ios(10.3));
> 
> s/VI/Vi

Done.

> 
> > Source/WebKit2/UIProcess/WKUserMediaProviderIOS.h:45
> > + at interface WKUserMediaProviderIOS : NSObject
> 
> Do you think it would be reasonable to have the same interface on Mac, and
> call this WKUserMediaProvider, and have it implemented perhaps in platform
> specific ways (or perhaps shared!).

Yes! It will have to be an interface and implemented differently on Mac and iOS because the AVFoundation APIs used in the class are platform specific, but I will make this change and implement it for iOS.

> 
> > Source/WebKit2/UIProcess/WKUserMediaProviderIOS.mm:56
> > +-(void)decidePolicyForUserMediaRequestFromOrigin:(SecurityOrigin&)userMediaOrigin topLevelOrigin:(SecurityOrigin&)topLevelOrigin frame:(WebFrameProxy&)frame request:(UserMediaPermissionRequestProxy&)permissionRequest view:(WKWebView*)view {
> 
> Space after the -, and before the star in WKWebView*

Done.

> 
> > Source/WebKit2/UIProcess/WebPageProxy.h:368
> > +    PageClient& pageClient() { return m_pageClient; }
> 
> This is surprising. The fact that it wasn't here before suggests that maybe
> it shouldn't be?

Hm maybe not. I exposed it because the UserMediaPermissionRequestManagerProxy is calling decidePolicyForUserMediaPermissionRequest on the page proxy's uiClient for the C API so I wanted to do something similar for the WebKit2 API, but perhaps it would make more sense to have UserMediaPermissionRequestManagerProxy call decidePolicyForUserMediaPermissionRequest on the page proxy directly and the page proxy can call the appropriate methods on the respective clients. 

Thanks for the review! V2 coming shortly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161108/5f37626f/attachment.html>