[Webkit-unassigned] [Bug 43239] Support for HTML Media Capture API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43239

--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 293962
  --> https://bugs.webkit.org/attachment.cgi?id=293962
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=293962&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:67
> +- (void)_webView:(WKWebView *)webVIew checkUserMediaPermissionForURL:(NSURL *)url mainFrameURL:(NSURL *)mainFrameURL frameIdentifier:(NSUInteger)frameIdentifier decisionHandler:(void (^)(NSString *salt, BOOL authorized))decisionHandler WK_API_AVAILABLE(ios(10.3));

s/VI/Vi

> Source/WebKit2/UIProcess/WKUserMediaProviderIOS.h:45
> + at interface WKUserMediaProviderIOS : NSObject

Do you think it would be reasonable to have the same interface on Mac, and call this WKUserMediaProvider, and have it implemented perhaps in platform specific ways (or perhaps shared!).

> Source/WebKit2/UIProcess/WKUserMediaProviderIOS.mm:56
> +-(void)decidePolicyForUserMediaRequestFromOrigin:(SecurityOrigin&)userMediaOrigin topLevelOrigin:(SecurityOrigin&)topLevelOrigin frame:(WebFrameProxy&)frame request:(UserMediaPermissionRequestProxy&)permissionRequest view:(WKWebView*)view {

Space after the -, and before the star in WKWebView*

> Source/WebKit2/UIProcess/WebPageProxy.h:368
> +    PageClient& pageClient() { return m_pageClient; }

This is surprising. The fact that it wasn't here before suggests that maybe it shouldn't be?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161107/cb73ceb4/attachment.html>