[Webkit-unassigned] [Bug 159398] [test262] Fixing mapped arguments object property test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 6 14:43:03 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=159398

--- Comment #77 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 294029
  --> https://bugs.webkit.org/attachment.cgi?id=294029
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294029&action=review

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:62
> +    if (index && thisObject->canAccessIndexQuickly(index.value()))

Why can we ever access an index quickly if we've modified an argument at that index? This seems weird to me.

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:232
> +            // property from arguments object are {writable: true, configurable: true, enumerable: true} by default

What if we modify configurable/enumuerable? Should we also stop mapping in such a scenario?
I'm confused why we have two vectors: modified/overrides. Can you explain why we need two of them?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161106/1682688d/attachment.html>


More information about the webkit-unassigned mailing list