[Webkit-unassigned] [Bug 158919] [GTK] HTTP auth layout tests are flaky

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 6 02:22:56 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=158919

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danw at gnome.org

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
These tests are flaky because they depend on previous auth tests. This explains why it started to fail after r195493 that doesn't change the expectations of these tests, but adds a test that also uses basic-auth-testing.php. So, if you run http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html and then http/tests/loading/basic-auth-resend-wrong-credentials.html in the same WTR you can see that the second one fails, because it first tries to use the credentials from the previous test (webkit/rocks). We don't receive the first challenge because libsoup already has credentials cached for that uri, but the load fails and we get a 401 and then the correct credentials are used and the authentication success as expected.
The problem is that WTR calls WKContextClearCachedCredentials() before every test in TestController::resetStateToConsistentValues(), and we remove the credentials from the WebCore storage, but libsoup still has its own cache. This proves that we didn0t really need to always padd credentials to soup in the url (see bug #139358), because libsoup always caches the values and use them when possible. So, the solution here to add libsoup API to clear the cached credentials.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161106/6fac18bd/attachment.html>


More information about the webkit-unassigned mailing list