[Webkit-unassigned] [Bug 164425] New: Web Inspector: WorkerTarget's mainResource should be a Resource not a Script

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164425

            Bug ID: 164425
           Summary: Web Inspector: WorkerTarget's mainResource should be a
                    Resource not a Script
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: joepeck at webkit.org
                CC: bburg at apple.com, joepeck at webkit.org,
                    mattbaker at apple.com, nvasilyev at apple.com,
                    timothy at apple.com,
                    webkit-bug-importer at group.apple.com, youennf at gmail.com

Summary:
WorkerTarget's mainResource should be a Resource not a Script

Currently, all Worker resource loads are RawResourceRequests. Such resources do not always get saved. In the past that was fine because they are typically ephemeral (XHR,Fetch, etc). However Worker resources are more like <script src="..."> and we should expect Web Inspector to be informed of them. This impacts Web Inspector in a few different ways:

    - If Web Inspector is opened after a page has loaded
      - Worker Script Resources are not guaranteed to exist so the frontend may not know about them
      - Worker Script Resources may show up as a Script instead of a Resource
        - being Script and not Resource, don't get a Resource Details Sidebar
        - being Script and not Resource, the Network tab won't have Resource load data
    - Web Inspector has a workaround converting the type from XHR -> Script in some places

Notes:
- WorkerScriptLoader issues ThreadableLoader requests that it knows will be Scripts. It would be good to type such requests as Script early on.
- Page.getResourceTree iterates over cachedResourceLoader().allCachedResources(). What determines that CachedResources for XHRs are not in that list?
  - Do they get removed from the list early on? Do they not even get added?

I do not know the best approach here, I'd like to talk with people more familiar with the Loader code to see what would be the right strategy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161104/13e19ac8/attachment-0001.html>