[Webkit-unassigned] [Bug 164390] New: REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164390

            Bug ID: 164390
           Summary: REGRESSION (r208349) StringHasher::hashMemory behavior
                    changed, causing API tests to fail
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: beidson at apple.com

REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail

Link to the change: https://trac.webkit.org/changeset/208349

The difference is that memory hashing used to mask the top 8 bits of the hash, just like string hashing needed.
Now it no longer does.

We can either restore the masking behavior, or accept the change in behavior (as an improvement, I think) and update the test.

Note: There was a FIXME in hashMemory that called out how odd it was that we masked the top 8 bits for memory hashing when it wasn't needed like for string hashing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161104/18149b5d/attachment.html>