No subject

Tue May 3 15:05:30 PDT 2016

> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:865
> +    Vector<RTCIceTransportState> transportStates;

I know this is untouched code.
Would you be able to use reserveInitialCapacity/uncheckedAppend

> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:870
> +    m_peerConnection.updateIceConnectionState(static_cast<RTCIceConnectionState>(derivedState));

This looks bad, deriveAggregatedIceConnectionState should really be changed to return RTCIceConnectionState.

-- 
You are receiving this mail because:
You are the assignee for the bug.

--Boundary_(ID_lYN5ovo0OtuYhr3o6RMGxA)
Date: Wed, 15 Mar 2017 15:43:33 -0700
MIME-version: 1.0
Content-type: text/html
Content-transfer-encoding: 7BIT

<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Follow-up on comments for bug 169664"
   href="https://bugs.webkit.org/show_bug.cgi?id=169709">169709</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Follow-up on comments for bug 169664
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>WebKit
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>WebKit Nightly Build
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>Unspecified
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Unspecified
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>Normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P2
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>WebKit Misc.
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>webkit-unassigned&#64;lists.webkit.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>jonlee&#64;apple.com
          </td>
        </tr></table>
      <p>
        <div>
        <pre>From Youenn:
<span class="quote">&gt; Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:865
&gt; +    Vector&lt;RTCIceTransportState&gt; transportStates;</span >

I know this is untouched code.
Would you be able to use reserveInitialCapacity/uncheckedAppend

<span class="quote">&gt; Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:870
&gt; +    m_peerConnection.updateIceConnectionState(static_cast&lt;RTCIceConnectionState&gt;(derivedState));</span >

This looks bad, deriveAggregatedIceConnectionState should really be changed to return RTCIceConnectionState.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>

--Boundary_(ID_lYN5ovo0OtuYhr3o6RMGxA)--