No subject

Tue May 3 15:05:30 PDT 2016

The code here:
https://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp#L1499

            childWidth = child.constrainLogicalWidthInRegionByMinMax(childWidth, childWidth, *this);

Should not pass childWidth() as the second argument -- that will lead to an incorrect percentage calculation for multiline column flexboxes or children with margins in a column flexbox. See the mentioned Chrome bug for a testcase. Fix should be to replace the second childWidth with contentLogicalWidth().

-- 
You are receiving this mail because:
You are the assignee for the bug.

--Boundary_(ID_+iNZOhC62vTiZa4UbQBAlg)
Date: Tue, 20 Dec 2016 07:05:41 -0800
MIME-version: 1.0
Content-type: text/html
Content-transfer-encoding: 7BIT

<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - RenderFlexibleBox::applyStretchAlignmentToChild uses wrong available width for constrainLogicalWidthInRegionByMinMax"
   href="https://bugs.webkit.org/show_bug.cgi?id=166061">166061</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>RenderFlexibleBox::applyStretchAlignmentToChild uses wrong available width for constrainLogicalWidthInRegionByMinMax
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>WebKit
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>WebKit Nightly Build
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>Unspecified
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Unspecified
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>Normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P2
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>Layout and Rendering
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>webkit-unassigned&#64;lists.webkit.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>cbiesinger&#64;chromium.org
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>simon.fraser&#64;apple.com
          </td>
        </tr></table>
      <p>
        <div>
        <pre>From Chrome bug <a href="https://bugs.chromium.org/p/chromium/issues/detail?id=675333">https://bugs.chromium.org/p/chromium/issues/detail?id=675333</a>

The code here:
<a href="https://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp#L1499">https://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp#L1499</a>

            childWidth = child.constrainLogicalWidthInRegionByMinMax(childWidth, childWidth, *this);

Should not pass childWidth() as the second argument -- that will lead to an incorrect percentage calculation for multiline column flexboxes or children with margins in a column flexbox. See the mentioned Chrome bug for a testcase. Fix should be to replace the second childWidth with contentLogicalWidth().</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>

--Boundary_(ID_+iNZOhC62vTiZa4UbQBAlg)--