[Webkit-unassigned] [Bug 157872] Our parser doesn't properly parse default parameter expressions in a class method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157872

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #280072|review?                     |review-
              Flags|                            |

--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 280072
  --> https://bugs.webkit.org/attachment.cgi?id=280072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280072&action=review

Looks good to me, but this patch needs tests before we can land it
I'd add parser tests. We have a file that is for these tests:
LayoutTests/js/parser-syntax-... (I forget the actual file name)
Also, please add some stress tests. I believe I added a fixme in a test
with this bug number. I think if you grep for this bug number you will
find it.

> Source/JavaScriptCore/parser/Parser.cpp:2074
> +        functionScope->setExpectedSuperBinding(expectedSuperBinding);

Can't this just be moved up to when we create the function scope?
Then the other place where we set this below can be deleted

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160530/64154dea/attachment.html>